fix: navigation delegation loops #1272
Conversation
…View configuration (apache#900)
… note: works around, rather than addresses existing architectural issues (apache#1031)
* issue_900_websiteDataStore: fix: update the existing tests of the default behavior feat: add CDVWebViewEngineConfigurationDelegate to fully expose WKWebView configuration (apache#900) # Conflicts: # CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
… conforming plugins use it
* issue_900_websiteDataStore: chore: bring back initWithFrame, as existing CDVWebViewEngineProtocol conforming plugins use it
…ation with configuration
…iewWithFrame chore: clean up newCordovaViewWithFrame in order to extract initializ…
* issue_900_websiteDataStore: chore: clean up newCordovaViewWithFrame in order to extract initialization with configuration
…/cordova-ios into issue_1031_delegates
|
Thanks for your patience; I've re-raised this PR now that I've gotten access at work again. |
|
Issue with the codecov.io setup? |
|
I'll rerun the test, I think that happens intermediately sometimes. |
|
Before I lose access again (through work), this one seems like it is good to go. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
- Coverage 78.26% 78.25% -0.02%
==========================================
Files 15 15
Lines 1767 1789 +22
==========================================
+ Hits 1383 1400 +17
- Misses 384 389 +5 ☔ View full report in Codecov by Sentry. |
We don't rely on the protocol itself being implemented by the plugins (we continue to check with `-respondsToSelector:`) but this allows us to avoid `objc_msgSend` and provides a way to document some of this plugin behaviour that is not otherwise explained. This should also resolve the unsafe plugin iteration issue that was mentioned in apacheGH-1272 and apacheGH-1030 by always iterating over an array of plugin objects that is a copy (due to calling `-allValues`).
We don't rely on the protocol itself being implemented by the plugins (we continue to check with `-respondsToSelector:`) but this allows us to avoid `objc_msgSend` and provides a way to document some of this plugin behaviour that is not otherwise explained. This should also resolve the unsafe plugin iteration issue that was mentioned in GH-1272 and GH-1030 by always iterating over an array of plugin objects that is a copy (due to calling `-allValues`).
|
Handled the loop issue slightly differently in #1479 but with the same idea of creating a copy of the map before iterating over the plugins. Also added synchronization to help ensure that we're not adding plugins while generating the copy of the values. Thanks for clearly explaining the problem! I intend to review the navigation policy stuff (in the context of additions like #1333) and will try to bring those changes in. |
note: works around, rather than addresses existing architectural issues (#1030)
note: should be reviewed after merging this related PR #1050
Platforms affected
cordova-ios
Motivation and Context
This is related to #1030, in that I noticed the existing looping/reflection pattern in CDVWebViewEngine was copied, and I wanted to provide an example of how to allow consumers to explicitly be delegates, so that pattern, which crashes, does not make its way in to other pieces of code.
Description
The existing behavior, that CDVViewController can be a WKNavigationDelegate, was not obvious, so I documented it. While it would be more explicit to set the navigation delegate in the designated initializer (like is done with the WKWebViewConfiguration), I did not want to drastically change what's being done here. The existing behavior also loops through the plugins and uses reflection to see if any handle specific WKNavigationDelegate methods. The way this is done can crash (is crashing in my production app), as the list of plugins can change while this loop iterates.
What I did change:
Testing
I've tested the existing behavior:
I've tested the new behavior:
Checklist
(platform)if this change only applies to one platform (e.g.(android))